RE: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h
From: Michael Kelley (LINUX) <hidden>
Date: 2023-07-10 05:22:41
Also in:
dri-devel, lkml
From: Sui Jingfeng <redacted> Sent: Sunday, July 9, 2023 3:05 AM
quoted hunk ↗ jump to hunk
drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':quoted
quoted
drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first usein this function) 1033 | base = screen_info.lfb_base; | ^~~~~~~~~~~ drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported only once for each function it appears in -- drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':quoted
quoted
drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared(first use in this function) 75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base, | ^~~~~~~~~~~ drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is reported only once for each function it appears in Reported-by: kernel test robot <redacted> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/ (local) Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures") Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header") Signed-off-by: Sui Jingfeng <redacted> --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.cb/drivers/gpu/drm/hyperv/hyperv_drm_drv.c index a7d2c92d6c6a..8026118c6e03 100644--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c@@ -7,6 +7,7 @@ #include <linux/hyperv.h> #include <linux/module.h> #include <linux/pci.h> +#include <linux/screen_info.h> #include <drm/drm_aperture.h> #include <drm/drm_atomic_helper.h> --2.25.1
Reviewed-by: Michael Kelley <redacted>