Thread (4 messages) 4 messages, 3 authors, 2023-02-08

Re: [PATCH net,v3] net: mana: Fix accessing freed irq affinity_hint

flat view

From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-02-08 05:41:14
Also in: lkml, netdev, stable

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski [off-list ref]:

On Mon,  6 Feb 2023 13:28:49 -0800 you wrote:
After calling irq_set_affinity_and_hint(), the cpumask pointer is
saved in desc->affinity_hint, and will be used later when reading
/proc/irq/<num>/affinity_hint. So the cpumask variable needs to be
persistent. Otherwise, we are accessing freed memory when reading
the affinity_hint file.

Also, need to clear affinity_hint before free_irq(), otherwise there
is a one-time warning and stack trace during module unloading:

[...]
Here is the summary with links:
  - [net,v3] net: mana: Fix accessing freed irq affinity_hint
    https://git.kernel.org/netdev/net/c/18a048370b06

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help