Re: [PATCH v4 01/25] KVM: x86: hyper-v: Expose access to debug MSRs in the partition privilege flags
From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-07-22 17:22:35
Also in:
kvm, lkml
On 7/21/22 23:43, Sean Christopherson wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c index c284a605e453..ca91547034e4 100644 --- a/arch/x86/kvm/hyperv.c +++ b/arch/x86/kvm/hyperv.c@@ -1282,7 +1282,7 @@ static bool hv_check_msr_access(struct kvm_vcpu_hv *hv_vcpu, u32 msr) case HV_X64_MSR_SYNDBG_OPTIONS: case HV_X64_MSR_SYNDBG_CONTROL ... HV_X64_MSR_SYNDBG_PENDING_BUFFER: return hv_vcpu->cpuid_cache.features_edx & - HV_FEATURE_DEBUG_MSRS_AVAILABLE; + HV_ACCESS_DEBUG_MSRS; default: break; }
Yes, and this will need some kind of hack in QEMU to expose both CPUID bits. Fortunately hv-syndbg shouldn't be in much use in the wild, so I think we can avoid quirks etc. Paolo