Re: [PATCH v3 07/34] x86/hyperv: Introduce HV_MAX_SPARSE_VCPU_BANKS/HV_VCPUS_PER_SPARSE_BANK constants
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: 2022-05-03 14:59:52
Also in:
kvm, lkml
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: 2022-05-03 14:59:52
Also in:
kvm, lkml
Christophe JAILLET [off-list ref] writes:
Le 14/04/2022 à 15:19, Vitaly Kuznetsov a écrit :
...
quoted
@@ -224,7 +225,7 @@ static inline int __cpumask_to_vpset(struct hv_vpset *vpset, * structs are not cleared between calls, we risk flushing unneeded * vCPUs otherwise. */ - for (vcpu_bank = 0; vcpu_bank <= hv_max_vp_index / 64; vcpu_bank++) + for (vcpu_bank = 0; vcpu_bank <= max_vcpu_bank; vcpu_bank++) vpset->bank_contents[vcpu_bank] = 0;and here: bitmap_clear(vpset->bank_contents, 0, hv_max_vp_index); or maybe even if it is safe to do so: bitmap_zero(vpset->bank_contents, hv_max_vp_index);
Both your suggestions (including the one for "PATCH v3 07/34]") look good to me, thanks! I'd however want to send them to linux-hyperv@ separately when this series lands through KVM tree just to not make this heavy series even heavier. -- Vitaly