On Sun, Feb 06, 2022 at 06:55:56AM -0800, Juan Vazquez wrote:

On Fri, Feb 04, 2022 at 01:30:08AM +0800, Miaoqian Lin wrote:

quoted

kobject_init_and_add() takes reference even when it fails.
According to the doc of kobject_init_and_add()：

   If this function returns an error, kobject_put() must be called to
   properly clean up the memory associated with the object.

Fix memory leak by calling kobject_put().

Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
Signed-off-by: Miaoqian Lin <redacted>
---
Changes in v2:
- Add cleanup when sysfs_create_group() fails

kobject_uevent() is used for notifying userspace by sending an uevent,
I don't think we need to do error handling for it.

Thanks for the patch. It looks good to me.

Reviewed-by: Juan Vazquez <redacted>

Applied to hyperv-fixes. Thanks.