Re: ** POTENTIAL FRAUD ALERT - RED HAT ** RE: [PATCH v2 8/8] KVM: x86: Add... | linux-hyperv

[PATCH v2 0/8] KVM: x86: Hyper-V hypercall fix and cleanups · Sean Christopherson <seanjc@google.com> · 2021-10-30
[PATCH v2 1/8] KVM: x86: Ignore sparse banks size for an "all CPUs", non-sparse IPI req · Sean Christopherson <seanjc@google.com> · 2021-10-30
Re: [PATCH v2 1/8] KVM: x86: Ignore sparse banks size for an "all CPUs", non-sparse IPI req · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-11-01
[PATCH v2 2/8] KVM: x86: Get the number of Hyper-V sparse banks from the VARHEAD field · Sean Christopherson <seanjc@google.com> · 2021-10-30
Re: [PATCH v2 2/8] KVM: x86: Get the number of Hyper-V sparse banks from the VARHEAD field · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-11-01
[PATCH v2 3/8] KVM: x86: Refactor kvm_hv_flush_tlb() to reduce indentation · Sean Christopherson <seanjc@google.com> · 2021-10-30
Re: [PATCH v2 3/8] KVM: x86: Refactor kvm_hv_flush_tlb() to reduce indentation · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-11-01
Re: [PATCH v2 3/8] KVM: x86: Refactor kvm_hv_flush_tlb() to reduce indentation · Sean Christopherson <seanjc@google.com> · 2021-12-03
[PATCH v2 4/8] KVM: x86: Add a helper to get the sparse VP_SET for IPIs and TLB flushes · Sean Christopherson <seanjc@google.com> · 2021-10-30
Re: [PATCH v2 4/8] KVM: x86: Add a helper to get the sparse VP_SET for IPIs and TLB flushes · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-11-01
[PATCH v2 5/8] KVM: x86: Don't bother reading sparse banks that end up being ignored · Sean Christopherson <seanjc@google.com> · 2021-10-30
Re: [PATCH v2 5/8] KVM: x86: Don't bother reading sparse banks that end up being ignored · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-11-01
[PATCH v2 6/8] KVM: x86: Shove vp_bitmap handling down into sparse_set_to_vcpu_mask() · Sean Christopherson <seanjc@google.com> · 2021-10-30
Re: [PATCH v2 6/8] KVM: x86: Shove vp_bitmap handling down into sparse_set_to_vcpu_mask() · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-11-01
[PATCH v2 7/8] KVM: x86: Reject fixeds-size Hyper-V hypercalls with non-zero "var_cnt" · Sean Christopherson <seanjc@google.com> · 2021-10-30
Re: [PATCH v2 7/8] KVM: x86: Reject fixeds-size Hyper-V hypercalls with non-zero "var_cnt" · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-11-01
Re: [PATCH v2 7/8] KVM: x86: Reject fixeds-size Hyper-V hypercalls with non-zero "var_cnt" · Sean Christopherson <seanjc@google.com> · 2021-12-03
[PATCH v2 8/8] KVM: x86: Add checks for reserved-to-zero Hyper-V hypercall fields · Sean Christopherson <seanjc@google.com> · 2021-10-30
Re: [PATCH v2 8/8] KVM: x86: Add checks for reserved-to-zero Hyper-V hypercall fields · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-11-01
Re: [PATCH v2 8/8] KVM: x86: Add checks for reserved-to-zero Hyper-V hypercall fields · Sean Christopherson <seanjc@google.com> · 2021-12-02
RE: [PATCH v2 8/8] KVM: x86: Add checks for reserved-to-zero Hyper-V hypercall fields · Michael Kelley (LINUX) <hidden> · 2021-12-02
Re: ** POTENTIAL FRAUD ALERT - RED HAT ** RE: [PATCH v2 8/8] KVM: x86: Add checks for reserved-to-zero Hyper-V hypercall fields · Vitaly Kuznetsov <vkuznets@redhat.com> · 2021-12-03

Re: POTENTIAL FRAUD ALERT - RED HAT RE: [PATCH v2 8/8] KVM: x86: Add checks for reserved-to-zero Hyper-V hypercall fields

From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: 2021-12-03 14:09:37
Also in: kvm, linux-arch, lkml

"Michael Kelley (LINUX)" [off-list ref] writes:

From: Sean Christopherson <seanjc@google.com> Sent: Wednesday, December 1, 2021 6:13 PM

quoted

On Mon, Nov 01, 2021, Vitaly Kuznetsov wrote:

quoted

Sean Christopherson [off-list ref] writes:

quoted

Add checks for the three fields in Hyper-V's hypercall params that must
be zero.  Per the TLFS, HV_STATUS_INVALID_HYPERCALL_INPUT is returned if
"A reserved bit in the specified hypercall input value is non-zero."

Note, the TLFS has an off-by-one bug for the last reserved field, which
it defines as being bits 64:60.  The same section states "The input field
64-bit value called a hypercall input value.", i.e. bit 64 doesn't
exist.

This version are you looking at? I can't see this issue in 6.0b

It's the web-based documentation, the 6.0b PDF indeed does not have the same bug.

https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/hypercall-interface#hypercall-inputs

Did you (or Vitaly) file a bug report on this doc issue?  If not, I can do so.

Done, https://github.com/MicrosoftDocs/Virtualization-Documentation/pull/1682

-- 
Vitaly

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help