Thread (3 messages) 3 messages, 3 authors, 2021-08-25

Re: [PATCH] hv_utils: Set the maximum packet size for VSS driver to the length of the receive buffer

From: Wei Liu <wei.liu@kernel.org>
Date: 2021-08-25 19:02:23
Also in: lkml

On Wed, Aug 25, 2021 at 06:33:10PM +0000, Michael Kelley wrote:
From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Wednesday, August 25, 2021 6:39 AM
quoted
Commit adae1e931acd ("Drivers: hv: vmbus: Copy packets sent by Hyper-V out
of the ring buffer") introduced a notion of maximum packet size and for
KVM and FCOPY drivers set it to the length of the receive buffer. VSS
driver wasn't updated, this means that the maximum packet size is now
VMBUS_DEFAULT_MAX_PKT_SIZE (4k). Apparently, this is not enough. I'm
observing a packet of 6304 bytes which is being truncated to 4096. When
VSS driver tries to read next packet from ring buffer it starts from the
wrong offset and receives garbage.

Set the maximum packet size to 'HV_HYP_PAGE_SIZE * 2' in VSS driver. This
matches the length of the receive buffer and is in line with other utils
drivers.

Fixes: adae1e931acd ("Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer")
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
[...]
Reviewed-by: Michael Kelley <redacted>
Given we're really close to the merge window I'm going to apply this to
hyperv-next.

Wei.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help