Re: [RFC v4 2/7] PCI: Allow msi domain set-up at host probing time
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-07-14 19:40:25
Also in:
linux-arm-kernel, linux-pci, lkml
Capitalize "MSI" in subject and commit log. On Wed, Jul 14, 2021 at 06:27:32PM +0800, Boqun Feng wrote:
For GENERIC_MSI_IRQ_DOMAIN drivers, we can set up the msi domain via dev_set_msi_domain() at probing time, and drivers can use this more generic way to set up the msi domain for the host bridge.
This doesn't tell me what this patch *does* or why we need it.
quoted hunk ↗ jump to hunk
This is the preparation for ARM64 Hyper-V PCI support. Originally-by: Arnd Bergmann [off-list ref] Signed-off-by: Boqun Feng <redacted> --- drivers/pci/probe.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 60c50d4f156f..539b5139e376 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c@@ -829,11 +829,14 @@ static struct irq_domain *pci_host_bridge_msi_domain(struct pci_bus *bus) { struct irq_domain *d; + /* Default set by host bridge driver */ + d = dev_get_msi_domain(bus->bridge);
Add blank line here between executable code and the following comment.
/* * Any firmware interface that can resolve the msi_domain * should be called from here. */ - d = pci_host_bridge_of_msi_domain(bus); + if (!d) + d = pci_host_bridge_of_msi_domain(bus); if (!d) d = pci_host_bridge_acpi_msi_domain(bus); -- 2.30.2