Thread (7 messages) flat view 7 messages, 3 authors, 2021-06-15

Re: [PATCH v2 -next] drm/hyperv: Fix unused const variable 'hyperv_modifiers'

From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2021-06-15 09:25:31
Also in: dri-devel, lkml

Hi

Am 15.06.21 um 05:14 schrieb Pu Lehui:
There is a gcc '-Wunused-const-variable' warning:
   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
     'hyperv_modifiers' defined but not used [-Wunused-const-variable=]

while the variable should be used in drm_simple_display_pipe_init()
as suggested by Thomas, let's fix it.
Thanks a lot! I added your patch to drm-misc-next-fixes.

Best regards
Thomas
quoted hunk ↗ jump to hunk
Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device")
Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
  drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 02718e3e859e..3aaee4730ec6 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
@@ -163,7 +163,7 @@ static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
  					   &hyperv_pipe_funcs,
  					   hyperv_formats,
  					   ARRAY_SIZE(hyperv_formats),
-					   NULL,
+					   hyperv_modifiers,
  					   &hv->connector);
  	if (ret)
  		return ret;
-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help