[PATCH -next] drm/hyperv: Remove unused variable

Fixes gcc '-Wunused-const-variable' warning:
  drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
    'hyperv_modifiers' defined but not used [-Wunused-const-variable=]

Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 02718e3e859e..3f83493909e6 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c

@@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {
 	DRM_FORMAT_XRGB8888,
 };
 
-static const uint64_t hyperv_modifiers[] = {
-	DRM_FORMAT_MOD_LINEAR,
-	DRM_FORMAT_MOD_INVALID
-};
-
 static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
 {
 	int ret;

-- 
2.17.1

Hi

Am 09.06.21 um 04:49 schrieb Pu Lehui:

This constant should rather be used in the call to 
drm_simple_display_pipe_init(). [1]

Best regards
Thomas

[1] 
https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161

-
  static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
  {
  	int ret;

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

On Wed, 2021-06-09 at 09:46 +0200, Thomas Zimmermann wrote:

Hi

Am 09.06.21 um 04:49 schrieb Pu Lehui:

quoted

Fixes gcc '-Wunused-const-variable' warning:
   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
     'hyperv_modifiers' defined but not used [-Wunused-const-
variable=]

Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
  drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c

b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 02718e3e859e..3f83493909e6 100644

--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c

@@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {

        DRM_FORMAT_XRGB8888,
  };
  
-static const uint64_t hyperv_modifiers[] = {
-       DRM_FORMAT_MOD_LINEAR,
-       DRM_FORMAT_MOD_INVALID
-};

This constant should rather be used in the call to 
drm_simple_display_pipe_init(). [1]

Best regards
Thomas

[1] 
https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161

Hi Pu,

Thanks for the patch. Is it possible to send another patch as per
suggestion by Thomas. There is a kernel test robot failure as well.

Deepak

On 2021/6/14 22:01, Deepak Rawat wrote:

On Wed, 2021-06-09 at 09:46 +0200, Thomas Zimmermann wrote:

quoted

Hi

Am 09.06.21 um 04:49 schrieb Pu Lehui:

quoted

Fixes gcc '-Wunused-const-variable' warning:
    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
      'hyperv_modifiers' defined but not used [-Wunused-const-
variable=]

Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
   1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c

b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 02718e3e859e..3f83493909e6 100644

--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c

@@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {
         DRM_FORMAT_XRGB8888,
   };
   
-static const uint64_t hyperv_modifiers[] = {
-       DRM_FORMAT_MOD_LINEAR,
-       DRM_FORMAT_MOD_INVALID
-};

This constant should rather be used in the call to
drm_simple_display_pipe_init(). [1]

Best regards
Thomas

[1]
https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161

Hi Pu,

Thanks for the patch. Is it possible to send another patch as per
suggestion by Thomas. There is a kernel test robot failure as well.

Deepak

.

Hi Deepak,

Thanks for your reply, I will send v2 soon.

Best regards
Lehui

There is a gcc '-Wunused-const-variable' warning:
  drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
    'hyperv_modifiers' defined but not used [-Wunused-const-variable=]

while the variable should be used in drm_simple_display_pipe_init()
as suggested by Thomas, let's fix it.

Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device")
Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 02718e3e859e..3aaee4730ec6 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c

@@ -163,7 +163,7 @@ static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
 					   &hyperv_pipe_funcs,
 					   hyperv_formats,
 					   ARRAY_SIZE(hyperv_formats),
-					   NULL,
+					   hyperv_modifiers,
 					   &hv->connector);
 	if (ret)
 		return ret;

-- 
2.17.1

On 2021/6/9 15:46, Thomas Zimmermann wrote:

Hi

Am 09.06.21 um 04:49 schrieb Pu Lehui:

quoted

Fixes gcc '-Wunused-const-variable' warning:
   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
     'hyperv_modifiers' defined but not used [-Wunused-const-variable=]

Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
  drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c 

b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 02718e3e859e..3f83493909e6 100644

--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c

@@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {

      DRM_FORMAT_XRGB8888,
  };
-static const uint64_t hyperv_modifiers[] = {
-    DRM_FORMAT_MOD_LINEAR,
-    DRM_FORMAT_MOD_INVALID
-};

This constant should rather be used in the call to 
drm_simple_display_pipe_init(). [1]

Best regards
Thomas

[1] 
https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161 

quoted

-
  static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
  {
      int ret;

Hi Thomas,

Thanks for your suggestion, I will fix it in v2.

Best regards
Lehui

Hi

Am 15.06.21 um 05:14 schrieb Pu Lehui:

There is a gcc '-Wunused-const-variable' warning:
   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
     'hyperv_modifiers' defined but not used [-Wunused-const-variable=]

while the variable should be used in drm_simple_display_pipe_init()
as suggested by Thomas, let's fix it.

Thanks a lot! I added your patch to drm-misc-next-fixes.

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer