Re: [PATCH] x86/hyperv: LP creation with lp_index on same CPU-id
From: Wei Liu <wei.liu@kernel.org>
Date: 2021-06-02 15:16:31
Also in:
lkml
From: Wei Liu <wei.liu@kernel.org>
Date: 2021-06-02 15:16:31
Also in:
lkml
On Mon, May 31, 2021 at 04:31:04PM +0530, Praveen Kumar wrote:
On 5/31/2021 4:27 PM, Wei Liu wrote:quoted
On Mon, May 31, 2021 at 01:10:46PM +0530, Praveen Kumar wrote:quoted
The hypervisor expects the lp_index to be same as cpu-id during LP creation This fix correct the same, as cpu_physical_id can give different cpu-id.Code looks fine to me, but the commit message can be made clearer. """ The hypervisor expects the logical processor index to be the same as CPU's id during logical processor creation. Using cpu_physical_id confuses Microsoft Hypervisor's scheduler. That causes the root partition not boot when core scheduler is used. This patch removes the call to cpu_physical_id and uses the CPU index directly for bringing up logical processor. This scheme works for both classic scheduler and core scheduler. Fixes: 333abaf5abb3 (x86/hyperv: implement and use hv_smp_prepare_cpus) """ No action is required from you. If you are fine with this commit message I can incorporate it and update the subject line when committing this patch.Thanks Wei for your comments. I'm fine with your inputs. Please go ahead. Thanks.
Pushed to hyperv-next. Thanks.