Re: [PATCH] pci-hyperv: Add check for hyperv_initialized in init_hv_pci_drv()
From: Wei Liu <wei.liu@kernel.org>
Date: 2021-06-02 10:32:13
Also in:
linux-pci, lkml
On Tue, May 25, 2021 at 04:17:33PM -0700, Haiyang Zhang wrote:
Add check for hv_is_hyperv_initialized() at the top of init_hv_pci_drv(), so if the pci-hyperv driver is force-loaded on non Hyper-V platforms, the init_hv_pci_drv() will exit immediately, without any side effects, like assignments to hvpci_block_ops, etc. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Reported-and-tested-by: Mohammad Alqayeem <redacted>
Hello PCI subsystem maintainers, are you going to take this patch or shall I? Wei.
quoted hunk ↗ jump to hunk
--- drivers/pci/controller/pci-hyperv.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index 6511648271b2..bebe3eeebc4e 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c@@ -3476,6 +3476,9 @@ static void __exit exit_hv_pci_drv(void) static int __init init_hv_pci_drv(void) { + if (!hv_is_hyperv_initialized()) + return -ENODEV; + /* Set the invalid domain number's bit, so it will not be used */ set_bit(HVPCI_DOM_INVALID, hvpci_dom_map);-- 2.25.1