Re: [PATCH 12/19] drivers/hv: run vp ioctl and isr

From: Wei Liu <wei.liu@kernel.org>
Date: 2021-05-29 21:55:57
Also in: lkml
Reply to: Nuno Das Neves, 2021-05-28

On Fri, May 28, 2021 at 03:43:32PM -0700, Nuno Das Neves wrote:
[...]

quoted hunk ↗ jump to hunk

 int mshv_synic_init(unsigned int cpu)
 {
 	union hv_synic_simp simp;

@@ -30,7 +126,7 @@ int mshv_synic_init(unsigned int cpu)
 	*msg_page = memremap(simp.base_simp_gpa << HV_HYP_PAGE_SHIFT,
 			     HV_HYP_PAGE_SIZE,
                              MEMREMAP_WB);
-	if (!msg_page) {
+	if (!(*msg_page)) {

This hunk belongs to the previous patch in which you introduced this
function, not this one.

Wei.

Nuno Das Neves · 2021-05-28
[PATCH 01/19] x86/hyperv: convert hyperv statuses to linux error codes · Nuno Das Neves · 2021-05-28
RE: [PATCH 01/19] x86/hyperv: convert hyperv statuses to linux error codes · Sunil Muthuswamy · 2021-06-10
[PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/) · Nuno Das Neves · 2021-05-28
Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/) · Randy Dunlap · 2021-05-29
Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/) · Nuno Das Neves · 2021-06-01
RE: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/) · Sunil Muthuswamy · 2021-06-03
Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/) · Nuno Das Neves · 2021-06-23
Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/) · Wei Liu · 2021-06-27
Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/) · Nuno Das Neves · 2021-07-06
[PATCH 02/19] asm-generic/hyperv: convert hyperv statuses to strings · Nuno Das Neves · 2021-05-28
RE: [PATCH 02/19] asm-generic/hyperv: convert hyperv statuses to strings · Sunil Muthuswamy · 2021-06-10
Re: [PATCH 02/19] asm-generic/hyperv: convert hyperv statuses to strings · Nuno Das Neves · 2021-06-23
[PATCH 04/19] drivers/hv: check extension ioctl · Nuno Das Neves · 2021-05-28
[PATCH 05/19] drivers/hv: create partition ioctl · Nuno Das Neves · 2021-05-28
[PATCH 06/19] drivers/hv: create, initialize, finalize, delete partition hypercalls · Nuno Das Neves · 2021-05-28
Re: [PATCH 06/19] drivers/hv: create, initialize, finalize, delete partition hypercalls · Wei Liu · 2021-06-01
Re: [PATCH 06/19] drivers/hv: create, initialize, finalize, delete partition hypercalls · Nuno Das Neves · 2021-06-01
[PATCH 07/19] drivers/hv: withdraw memory hypercall · Nuno Das Neves · 2021-05-28
[PATCH 08/19] drivers/hv: map and unmap guest memory · Nuno Das Neves · 2021-05-28
[PATCH 09/19] drivers/hv: create vcpu ioctl · Nuno Das Neves · 2021-05-28
[PATCH 10/19] drivers/hv: get and set vcpu registers ioctls · Nuno Das Neves · 2021-05-28
Re: [PATCH 10/19] drivers/hv: get and set vcpu registers ioctls · kernel test robot · 2021-05-29
[PATCH 11/19] drivers/hv: set up synic pages for intercept messages · Nuno Das Neves · 2021-05-28
Re: [PATCH 11/19] drivers/hv: set up synic pages for intercept messages · kernel test robot · 2021-05-29
[PATCH 12/19] drivers/hv: run vp ioctl and isr · Nuno Das Neves · 2021-05-28
Re: [PATCH 12/19] drivers/hv: run vp ioctl and isr · Wei Liu · 2021-05-29
Re: [PATCH 12/19] drivers/hv: run vp ioctl and isr · Nuno Das Neves · 2021-06-01
[PATCH 14/19] drivers/hv: assert interrupt ioctl · Nuno Das Neves · 2021-05-28
[PATCH 13/19] drivers/hv: install intercept ioctl · Nuno Das Neves · 2021-05-28
[PATCH 15/19] drivers/hv: get and set vp state ioctls · Nuno Das Neves · 2021-05-28
[PATCH 16/19] drivers/hv: mmap vp register page · Nuno Das Neves · 2021-05-28
[PATCH 18/19] drivers/hv: Add enlightenment bits to create partition ioctl · Nuno Das Neves · 2021-05-28
[PATCH 17/19] drivers/hv: get and set partition property ioctls · Nuno Das Neves · 2021-05-28
[PATCH 19/19] drivers/hv: Translate GVA to GPA · Nuno Das Neves · 2021-05-28
Vitaly Kuznetsov · 2021-06-10
Nuno Das Neves · 2021-06-23
View all 37 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help