Thread (10 messages) flat view 10 messages, 4 authors, 2021-02-18

Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

From: Deepak Rawat <hidden>
Date: 2021-02-17 16:10:12
Also in: dri-devel

On Wed, 2021-02-17 at 13:22 +0000, Simon Ser wrote:
On Tuesday, February 16th, 2021 at 1:39 AM, Deepak Rawat <
drawat.floss@gmail.com> wrote:
quoted
+static int hyperv_conn_init(struct hyperv_drm_device *hv)
+{
+       drm_connector_helper_add(&hv->connector,
&hyperv_connector_helper_funcs);
+       return drm_connector_init(&hv->dev, &hv->connector,
+                                 &hyperv_connector_funcs,
+                                 DRM_MODE_CONNECTOR_VGA);
+}
Nit: shouldn't this be DRM_MODE_CONNECTOR_Virtual?
Thanks Simon for the review, I think it make sense to use
DRM_MODE_CONNECTOR_Virtual.


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help