Re: [PATCH v9 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening
From: Wei Liu <wei.liu@kernel.org>
Date: 2020-11-17 10:54:43
Also in:
linux-scsi, lkml, netdev
From: Wei Liu <wei.liu@kernel.org>
Date: 2020-11-17 10:54:43
Also in:
linux-scsi, lkml, netdev
On Mon, Nov 09, 2020 at 11:03:59AM +0100, Andrea Parri (Microsoft) wrote:
Currently, VMbus drivers use pointers into guest memory as request IDs for interactions with Hyper-V. To be more robust in the face of errors or malicious behavior from a compromised Hyper-V, avoid exposing guest memory addresses to Hyper-V. Also avoid Hyper-V giving back a bad request ID that is then treated as the address of a guest data structure with no validation. Instead, encapsulate these memory addresses and provide small integers as request IDs. The first patch creates the definitions for the data structure, provides helper methods to generate new IDs and retrieve data, and allocates/frees the memory needed for vmbus_requestor. The second and third patches make use of vmbus_requestor to send request IDs to Hyper-V in storvsc and netvsc respectively. The series is based on 5.10-rc3. Changelog in the actual patches.
Applied to hyperv-next. Thanks. I also corrected the email address in my reviewed-by tags while committing -- should've use my @kernel.org address, not @xen.org. Wei.