Re: [RFC] MAINTAINERS tag for cleanup robot
From: Joe Perches <joe@perches.com>
Date: 2020-11-21 17:10:41
Also in:
alsa-devel, amd-gfx, bpf, dri-devel, intel-gfx, keyrings, kvm, linux-acpi, linux-bluetooth, linux-crypto, linux-fbdev, linux-fsdevel, linux-media, linux-nfs, linux-omap, linux-scsi, linux-usb, linux-wireless, lkml, netdev, netfilter-devel, platform-driver-x86, xen-devel
On Sat, 2020-11-21 at 08:50 -0800, trix@redhat.com wrote:
A difficult part of automating commits is composing the subsystem preamble in the commit log. For the ongoing effort of a fixer producing one or two fixes a release the use of 'treewide:' does not seem appropriate. It would be better if the normal prefix was used. Unfortunately normal is not consistent across the tree. So I am looking for comments for adding a new tag to the MAINTAINERS file D: Commit subsystem prefix ex/ for FPGA DFL DRIVERS D: fpga: dfl:
I'm all for it. Good luck with the effort. It's not completely trivial. From a decade ago: https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/ (local) (and that thread started with extra semicolon patches too)
Continuing with cleaning up clang's -Wextra-semi-stmt
quoted hunk ↗ jump to hunk
diff --git a/Makefile b/Makefile
[]
quoted hunk ↗ jump to hunk
@@ -1567,20 +1567,21 @@ help:echo '' @echo 'Static analysers:' @echo ' checkstack - Generate a list of stack hogs' @echo ' versioncheck - Sanity check on version.h usage' @echo ' includecheck - Check for duplicate included header files' @echo ' export_report - List the usages of all exported symbols' @echo ' headerdep - Detect inclusion cycles in headers' @echo ' coccicheck - Check with Coccinelle' @echo ' clang-analyzer - Check with clang static analyzer' @echo ' clang-tidy - Check with clang-tidy' + @echo ' clang-tidy-fix - Check and fix with clang-tidy'
A pity the ordering of the code below isn't the same as the above.
-PHONY += clang-tidy clang-analyzer +PHONY += clang-tidy-fix clang-tidy clang-analyzer
[]
-clang-tidy clang-analyzer: $(extmod-prefix)compile_commands.json +clang-tidy-fix clang-tidy clang-analyzer: $(extmod-prefix)compile_commands.json $(call cmd,clang_tools) else -clang-tidy clang-analyzer: +clang-tidy-fix clang-tidy clang-analyzer:
[]
quoted hunk ↗ jump to hunk
diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
[]
quoted hunk ↗ jump to hunk
@@ -22,43 +22,57 @@ def parse_arguments():
[]
parser.add_argument("type",
- choices=["clang-tidy", "clang-analyzer"],
+ choices=["clang-tidy-fix", "clang-tidy", "clang-analyzer"],etc...