Re: [PATCH v1] hv_balloon: disable warning when floor reached
From: Wei Liu <wei.liu@kernel.org>
Date: 2020-10-19 13:42:14
Also in:
lkml
On Mon, Oct 19, 2020 at 03:02:22AM +0000, Michael Kelley wrote:
From: Olaf Hering <redacted> Sent: Thursday, October 8, 2020 12:12 AMquoted
It is not an error if a the host requests to balloon down, but the VMSpurious word "a"quoted
refuses to do so. Without this change a warning is logged in dmesg every five minutes. Fixes commit b3bb97b8a49f3This "Fixes" line isn't formatted correctly. Should be: Fixes: b3bb97b8a49f3 ("Drivers: hv: balloon: Add logging for dynamic memory operations")quoted
Signed-off-by: Olaf Hering <redacted> --- drivers/hv/hv_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index 32e3bc0aa665..0f50295d0214 100644 --- a/drivers/hv/hv_balloon.c +++ b/drivers/hv/hv_balloon.c@@ -1275,7 +1275,7 @@ static void balloon_up(struct work_struct *dummy) /* Refuse to balloon below the floor. */ if (avail_pages < num_pages || avail_pages - num_pages < floor) { - pr_warn("Balloon request will be partially fulfilled. %s\n", + pr_info("Balloon request will be partially fulfilled. %s\n", avail_pages < num_pages ? "Not enough memory." : "Balloon floor reached.");Above nits notwithstanding, Reviewed-by: Michael Kelley <redacted>
Thanks. I see one for and no against so far. I've applied this patch to hyperv-fixes. I also fixed those nits while at it. Wei.