Thread (4 messages) 4 messages, 2 authors, 2020-08-27

Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code

From: Iouri Tarassov <hidden>
Date: 2020-08-27 19:09:15
Also in: lkml

Possibly related (same subject, not in this thread)

Thank you,Wei. These issues will be fixed in the next patchset.

Iouri

On 8/14/2020 6:18 AM, Wei Liu wrote:
On Fri, Aug 14, 2020 at 08:38:53AM -0400, Sasha Levin wrote:
[...]
quoted
+
+#include "dxgkrnl.h"
+
+int dxgadapter_init(struct dxgadapter *adapter, struct hv_device *hdev)
+{
+	int ret = 0;
+	char s[80];
+
+	UNUSED(s);
If s is not used, why not just remove it?

Indeed it is not used anywhere in this function. That saves you 80 bytes
on stack.
quoted
+static int dxgk_destroy_hwcontext(struct dxgprocess *process,
+					      void *__user inargs)
+{
+	/* This is obsolete entry point */
+	return ENOTTY;
+}
+
Other places have been using negative numbers for errors. I guess you
want -ENOTTY here too.

Wei.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help