Re: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening
From: Wei Liu <wei.liu@kernel.org>
Date: 2020-06-29 22:26:23
Also in:
lkml, netdev
From: Wei Liu <wei.liu@kernel.org>
Date: 2020-06-29 22:26:23
Also in:
lkml, netdev
On Mon, Jun 29, 2020 at 09:33:15PM +0000, Haiyang Zhang wrote:
quoted
-----Original Message----- From: Andres Beltran <redacted> Sent: Monday, June 29, 2020 4:02 PM To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang [off-list ref]; Stephen Hemminger [off-list ref]; wei.liu@kernel.org Cc: linux-hyperv@vger.kernel.org; linux-kernel@vger.kernel.org; Michael Kelley [off-list ref]; parri.andrea@gmail.com; Andres Beltran [off-list ref]; David S . Miller [off-list ref]; Jakub Kicinski [off-list ref]; netdev@vger.kernel.org Subject: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening Currently, pointers to guest memory are passed to Hyper-V as transaction IDs in netvsc. In the face of errors or malicious behavior in Hyper-V, netvsc should not expose or trust the transaction IDs returned by Hyper-V to be valid guest memory addresses. Instead, use small integers generated by vmbus_requestor as requests (transaction) IDs. Cc: David S. Miller <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: netdev@vger.kernel.org Signed-off-by: Andres Beltran <redacted>Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Thanks Haiyang for reviewing. David and Jakub: This patch depends on the first patch. I intend to pick up this patch via hyperv.git. This makes life easier for all of us. Let me know if you disagree. Wei.