Thread (4 messages) 4 messages, 3 authors, 2020-05-11

RE: [PATCH v3 2/2] PCI: hv: Retry PCI bus D0 entry when the first attempt failed with invalid device state

From: Wei Hu <hidden>
Date: 2020-05-11 14:11:33
Also in: linux-pci, lkml

-----Original Message-----
From: Lorenzo Pieralisi <redacted>
Sent: Monday, May 11, 2020 7:21 PM
To: Wei Hu <redacted>
Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
[off-list ref]; Stephen Hemminger [off-list ref];
wei.liu@kernel.org; robh@kernel.org; bhelgaas@google.com; linux-
hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
kernel@vger.kernel.org; Dexuan Cui [off-list ref]; Michael Kelley
[off-list ref]
Subject: Re: [PATCH v3 2/2] PCI: hv: Retry PCI bus D0 entry when the first
attempt failed with invalid device state

On Thu, May 07, 2020 at 01:03:00PM +0800, Wei Hu wrote:
quoted
In the case of kdump, the PCI device was not cleanly shut down before
the kdump kernel starts. This causes the initial attempt of entering
D0 state in the kdump kernel to fail with invalid device state
returned from Hyper-V host.
When this happens, explicitly call PCI bus exit and retry to enter the
D0 state.

Signed-off-by: Wei Hu <redacted>
---
    v2: Incorporate review comments from Michael Kelley, Dexuan Cui and
    Bjorn Helgaas

 drivers/pci/controller/pci-hyperv.c | 40
+++++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)
Subject: exceeded 80 chars and commit log needed rewording and paragraphs
rewrapping. I did it this time but please pay attention to commit log content
(and format).
Got it. Thanks much for correcting it for me this time!

Wei
Thanks,
Lorenzo
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help