Thread (3 messages) 3 messages, 2 authors, 2019-08-28

RE: [PATCH v3] video: hyperv: hyperv_fb: Obtain screen resolution from Hyper-V host

From: Michael Kelley <hidden>
Date: 2019-08-27 23:56:48
Also in: dri-devel, linux-fbdev, lkml

From: Wei Hu <redacted> Sent: Tuesday, August 27, 2019 4:09 AM
Beginning from Windows 10 RS5+, VM screen resolution is obtained from host.
The "video=hyperv_fb" boot time option is not needed, but still can be
used to overwrite what the host specifies. The VM resolution on the host
could be set by executing the powershell "set-vmvideo" command.

v2:
- Implemented fallback when version negotiation failed.
- Defined full size for supported_resolution array.

v3:
- Corrected the synthvid major and minor version comparison problem.
The changelog for v2 and v3 should actually go after the "---" below so
that the changelog does not end up as part of the commit message.  Take
a look at other postings to LKML for an example.
Signed-off-by: Iouri Tarassov <redacted>
Signed-off-by: Wei Hu <redacted>
---
 drivers/video/fbdev/hyperv_fb.c | 159 +++++++++++++++++++++++++++++---
 1 file changed, 147 insertions(+), 12 deletions(-)


+/* Check if the ver1 version is equal or greater than ver2 */
+static inline bool synthvid_ver_eg(u32 ver1, u32 ver2)
I'm being picky here, but I would call this synthvid_ver_ge().   In my
experience "ge" is the shorthand for "greater than or equal", rather
than the "eg" you have used.

Michael

+{
+	if (SYNTHVID_VER_GET_MAJOR(ver1) > SYNTHVID_VER_GET_MAJOR(ver2) ||
+	    (SYNTHVID_VER_GET_MAJOR(ver1) == SYNTHVID_VER_GET_MAJOR(ver2) &&
+	     SYNTHVID_VER_GET_MINOR(ver1) >= SYNTHVID_VER_GET_MINOR(ver2)))
+		return true;
+
+	return false;
+}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help