Re: [PATCH] x86/Hyper-V: Fix build error with CONFIG_HYPERV_TSCPAGE=N
From: Tianyu Lan <hidden>
Date: 2019-08-26 03:32:13
Also in:
lkml
From: Tianyu Lan <hidden>
Date: 2019-08-26 03:32:13
Also in:
lkml
On Sun, Aug 25, 2019 at 1:52 AM Sasha Levin [off-list ref] wrote:
On Thu, Aug 22, 2019 at 10:39:46AM +0200, Vitaly Kuznetsov wrote:quoted
lantianyu1986@gmail.com writes:quoted
From: Tianyu Lan <redacted> Both Hyper-V tsc page and Hyper-V tsc MSR code use variable hv_sched_clock_offset for their sched clock callback and so define the variable regardless of CONFIG_HYPERV_TSCPAGE setting.CONFIG_HYPERV_TSCPAGE is gone after my "x86/hyper-v: enable TSC page clocksource on 32bit" patch. Do we still have an issue to fix?Yes. Let's get it fixed on older kernels (as such we need to tag this one for stable). The 32bit TSC patch won't come in before 5.4 anyway. Vitaly, does can you ack this patch? It might require you to re-spin your patch.
Hi Sasha:
Thomas has foled this fix into original patch.
https://lkml.org/lkml/2019/8/23/600
--
Best regards
Tianyu Lan