Hi Thomas:
               Thanks for your review. Will fix your comment in the
next version.

On Mon, Aug 19, 2019 at 9:27 PM Thomas Gleixner [off-list ref] wrote:

On Mon, 19 Aug 2019, lantianyu1986@gmail.com wrote:

quoted

From: Tianyu Lan <redacted>

This patch adds

Same git grep command as before

quoted

 new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH and let

baseball cap? Please do not use weird acronyms. This is text and there is
not limitation on characters.

quoted

user space to enable direct tlb flush function when only Hyper-V
hypervsior capability is exposed to VM.

Sorry, but I'm not understanding this sentence.

quoted

This patch also adds

Once more

quoted

enable_direct_tlbflush callback in the struct kvm_x86_ops and
platforms may use it to implement direct tlb flush support.

Please tell in the changelog WHY you are doing things not what. The what is
obviously in the patch.

So you want to explain what you are trying to achieve and why it is
useful. Then you can add a short note about what you are adding, but not at
the level of detail which is available from the diff itself.

Thanks,

        tglx

--
Best regards
Tianyu Lan