Thread (6 messages) 6 messages, 3 authors, 2019-07-03

Re: [PATCH] PCI: hv: fix pci-hyperv build, depends on SYSFS

From: Matthew Wilcox <willy@infradead.org>
Date: 2019-07-03 01:33:19
Also in: linux-pci, lkml

On Tue, Jul 02, 2019 at 04:24:30PM -0700, Randy Dunlap wrote:
From: Randy Dunlap <redacted>

Fix build errors when building almost-allmodconfig but with SYSFS
not set (not enabled).  Fixes these build errors:

ERROR: "pci_destroy_slot" [drivers/pci/controller/pci-hyperv.ko] undefined!
ERROR: "pci_create_slot" [drivers/pci/controller/pci-hyperv.ko] undefined!

drivers/pci/slot.o is only built when SYSFS is enabled, so
pci-hyperv.o has an implicit dependency on SYSFS.
Make that explicit.
I wonder if we shouldn't rather provide no-op versions of
pci_create|destroy_slot for when SYSFS is not set?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help