Thread (12 messages) 12 messages, 3 authors, 2019-06-17

RE: [PATCH net] hvsock: fix epollout hang from race condition

From: Dexuan Cui <decui@microsoft.com>
Date: 2019-06-13 23:36:03
Also in: lkml, netdev

From: Sunil Muthuswamy <redacted>
Sent: Wednesday, June 12, 2019 2:19 PM
 ...
The fix is to set the pending size to the default size and never change it.
This way the host will always notify the guest whenever the writable space
is bigger than the pending size. The host is already optimized to *only*
notify the guest when the pending size threshold boundary is crossed and
not everytime.

This change also reduces the cpu usage somewhat since
hv_stream_has_space()
is in the hotpath of send:
vsock_stream_sendmsg()->hv_stream_has_space()
Earlier hv_stream_has_space was setting/clearing the pending size on every
call.

Signed-off-by: Sunil Muthuswamy <redacted>
Hi Sunil, thanks for the fix! It looks good.

Reviewed-by: Dexuan Cui <decui@microsoft.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help