Thread (2 messages) 2 messages, 2 authors, 25d ago
COLD25d

[PATCH] gpio: altera: Fix build failure caused by undeclared 'irq'

From: <hidden>
Date: 2026-09-03 03:07:42
Also in: lkml
Subsystem: altera pio driver, gpio subsystem, the rest · Maintainers: Adrian Ng, Linus Walleij, Bartosz Golaszewski, Linus Torvalds

From: bui duc phuc <redacted>

Use 'mapped_irq' instead of the undefined 'irq' variable in
altera_gpio_probe().

The incorrect variable name causes the driver to fail to build with
an 'irq' undeclared error.

Fixes: 6e6e585b603e4 ("gpio: altera: Handle errors from optional IRQ lookup")
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/apgNYDiSiPmNZspF@sirena.org.uk/ (local)
Signed-off-by: bui duc phuc <redacted>
---
 drivers/gpio/gpio-altera.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
index d22f5be00745..a6ac9356229c 100644
--- a/drivers/gpio/gpio-altera.c
+++ b/drivers/gpio/gpio-altera.c
@@ -221,8 +221,8 @@ static int altera_gpio_probe(struct platform_device *pdev)
 
 	mapped_irq = platform_get_irq_optional(pdev, 0);
 	if (mapped_irq < 0) {
-		if (irq != -ENXIO)
-			return irq;
+		if (mapped_irq != -ENXIO)
+			return mapped_irq;
 		goto skip_irq;
 	}
 
-- 
2.43.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help