Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get
From: Bartosz Golaszewski <brgl@kernel.org>
Date: 2026-02-19 10:48:15
Also in:
linux-media, lkml
On Wed, 18 Feb 2026 21:53:48 +0100, Dmitry Torokhov [off-list ref] said:
quoted hunk ↗ jump to hunk
The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by max9286_gpiochip_get() is normalized to the [0, 1] range. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/media/i2c/max9286.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index e6e214f8294b..ac0712ce1e65 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c@@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset) { struct max9286_priv *priv = gpiochip_get_data(chip); - return priv->gpio_state & BIT(offset); + return !!(priv->gpio_state & BIT(offset)); } static int max9286_register_gpio(struct max9286_priv *priv) --2.53.0.335.g19a08e0c02-goog -- Dmitry
Reviewed-by: Bartosz Golaszewski <redacted>