Thread (16 messages) 16 messages, 7 authors, 2022-01-18

Re: [PATCH V2 1/4] pinctrl: imx: prepare for making "group_names" in "function_desc" const

From: Linus Walleij <hidden>
Date: 2021-12-22 01:58:15
Also in: linux-arm-kernel

On Thu, Dec 16, 2021 at 5:22 PM Rafał Miłecki [off-list ref] wrote:
From: Rafał Miłecki <rafal@milecki.pl>

The plan for "struct function_desc" is to make its "group_names"
/double/ const. That will allow drivers to use it with static const
data.

This imx change is required to avoid:
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_parse_functions':
drivers/pinctrl/freescale/pinctrl-imx.c:672:24: error: assignment of read-only location '*(func->group_names + (sizetype)(i * 4))'
  672 |   func->group_names[i] = child->name;
      |                        ^

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Patches applied, let's see what happens!

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help