Thread (2 messages) 2 messages, 2 authors, 2021-12-23

Re: [PATCH v1 1/1] gpio: brcmstb: Use local variable to access OF node

From: Bartosz Golaszewski <hidden>
Date: 2021-12-23 16:09:32
Also in: linux-arm-kernel, lkml

On Thu, Dec 23, 2021 at 2:15 PM Andy Shevchenko
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
We already have a local variable that contains a copy of OF node pointer.
Use it instead of dereferencing it again from struct device.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-brcmstb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index 176c264bb959..74ef89248867 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -704,7 +704,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
                }

                gc->owner = THIS_MODULE;
-               gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
+               gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
                if (!gc->label) {
                        err = -ENOMEM;
                        goto fail;
--
2.34.1
Applied, thanks!

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help