[PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node

Subsystems: gpio subsystem, the rest

STALE1680d

4 messages, 2 authors, 2022-01-24 · open the first message on its own page

[PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-23 12:27:31

GPIO library now accepts fwnode as a firmware node, so
switch the driver to use it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-altera-a10sr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c
index 6af51feda06f..be1ed7ee5225 100644
--- a/drivers/gpio/gpio-altera-a10sr.c
+++ b/drivers/gpio/gpio-altera-a10sr.c
@@ -10,6 +10,7 @@
 #include <linux/gpio/driver.h>
 #include <linux/mfd/altera-a10sr.h>
 #include <linux/module.h>
+#include <linux/property.h>
 
 /**
  * struct altr_a10sr_gpio - Altera Max5 GPIO device private data structure
@@ -88,7 +89,7 @@ static int altr_a10sr_gpio_probe(struct platform_device *pdev)
 
 	gpio->gp = altr_a10sr_gc;
 	gpio->gp.parent = pdev->dev.parent;
-	gpio->gp.of_node = pdev->dev.of_node;
+	gpio->gp.fwnode = dev_fwnode(&pdev->dev);
 
 	return devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
 }
-- 
2.34.1

Re: [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2022-01-05 14:32:57

On Thu, Dec 23, 2021 at 02:27:33PM +0200, Andy Shevchenko wrote:
GPIO library now accepts fwnode as a firmware node, so
switch the driver to use it.
Any comments on this?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node

From: Linus Walleij <hidden>
Date: 2022-01-16 00:24:16

On Thu, Dec 23, 2021 at 1:27 PM Andy Shevchenko
[off-list ref] wrote:
GPIO library now accepts fwnode as a firmware node, so
switch the driver to use it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
LGTM!
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

Re: [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2022-01-24 15:12:48

On Sun, Jan 16, 2022 at 01:24:02AM +0100, Linus Walleij wrote:
On Thu, Dec 23, 2021 at 1:27 PM Andy Shevchenko
[off-list ref] wrote:
quoted
GPIO library now accepts fwnode as a firmware node, so
switch the driver to use it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
LGTM!
Reviewed-by: Linus Walleij <redacted>
Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help