On Mon, Dec 20, 2021 at 4:11 PM Andy Shevchenko
[off-list ref] wrote:

On Mon, Dec 20, 2021 at 5:09 PM Bartosz Golaszewski [off-list ref] wrote:

quoted

On Mon, Dec 20, 2021 at 2:24 PM Andy Shevchenko
[off-list ref] wrote:

quoted

After the commit 448cf90513d9 ("gpio: Get rid of duplicate of_node
assignment in the drivers") the OF node local pointers become unused.
Remove them for good and make compiler happy about.

Fixes: 448cf90513d9 ("gpio: Get rid of duplicate of_node assignment in the drivers")
Reported-by: Stephen Rothwell <redacted>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

quoted

quoted

-               gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
+               gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);

This is unrelated though. Can you make it a separate patch?

It actually makes use of the local np IIRC.
It's related, no?

No, the np pointer is already used elsewhere. You just replace the
dev->of_node here with np. Rightfully so, but it's not part of this
commit logically.

Bart