On Mon, Dec 06, 2021 at 03:48:39PM +0200, Andy Shevchenko wrote:

On Mon, Dec 06, 2021 at 02:40:36PM +0100, Bartosz Golaszewski wrote:

quoted

On Mon, Dec 6, 2021 at 2:34 PM Andy Shevchenko
[off-list ref] wrote:

quoted

On Mon, Dec 06, 2021 at 09:41:33AM +0100, Bartosz Golaszewski wrote:

quoted

On Fri, Dec 3, 2021 at 9:10 PM Andy Shevchenko
[off-list ref] wrote:

...

quoted

This series concerns the gpio-sim driver and it only uses configfs
(with manually created platform devices) or device-tree. I would
prefer to do ACPI separately and I'd like you to lead that because I
neither have any HW to test nor claim to understand it. :)

Please, mention this in the commit message that ACPI is not covered (yet).

But the commit message says: "gpiolib: of: make fwnode take precedence
in struct gpio_chip" - it says OF right here. :)

It implies that reader should have a 6th sense to know about ACPI and what
else? Please, be explicit over implicit.

The problem here is that you change one case and haven't touched the rest which
brings inconsistency in the behaviour on different resource providers.

We need a record to be sure what disbalance this patch brought. That's why
I asked to mention ACPI branch.

-- 
With Best Regards,
Andy Shevchenko