Re: [PATCH v1 1/1] gpio: dwapb: clarify usage of the register file version

On Wed, Dec 01, 2021 at 03:27:34PM +0300, Serge Semin wrote:

On Tue, Nov 30, 2021 at 06:49:56PM +0200, Andy Shevchenko wrote:

quoted

First of all, it's obvious that different versions can't be provided
simultaneously. Hence, versions can't be bit masks.

Second, due to above we have to mask out the version field in the flags
and only that can be evaluated against the certain version.

Clarify all above by:
 - introducing GPIO_REG_OFFSET_V1 and GPIO_REG_OFFSET_MASK
 - replacing conditional to mask out bits and compare to a version

Luckily there is no functional change (at least intended), so no need
to backport this.

Seems reasonable. Thanks.
Acked-by: Serge Semin <redacted>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko