Re: [PATCH v3 1/2] gpiolib: improve coding style for local variables
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-11-24 14:35:56
Also in:
lkml
On Wed, Nov 24, 2021 at 01:28:49PM +0100, Bartosz Golaszewski wrote:
Drop unneeded whitespaces and put the variables of the same type together for consistency with the rest of the code.
I thought I gave my tag, nevermind, here we are Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Bartosz Golaszewski <redacted> Reviewed-by: Linus Walleij <redacted> --- v1 -> v2: - keep initializations on separate lines drivers/gpio/gpiolib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index abfbf546d159..ede8b8a7aa18 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c@@ -594,11 +594,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, struct lock_class_key *request_key) { struct fwnode_handle *fwnode = gc->parent ? dev_fwnode(gc->parent) : NULL; - unsigned long flags; - int ret = 0; - unsigned i; - int base = gc->base; struct gpio_device *gdev; + unsigned long flags; + int base = gc->base; + unsigned int i; + int ret = 0; /* * First: allocate and populate the internal stat container, and-- 2.25.1
-- With Best Regards, Andy Shevchenko