Thread (4 messages) 4 messages, 3 authors, 2021-10-30

Re: [PATCH] gpio: realtek-otto: fix GPIO line IRQ offset

From: Bartosz Golaszewski <hidden>
Date: 2021-10-30 15:00:03

On Thu, Oct 28, 2021 at 10:52 AM Sander Vanheule [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The irqchip uses one domain for all GPIO lines, so the line offset
should be determined w.r.t. the first line of the first port, not the
first line of the triggered port.

Fixes: 0d82fb1127fb ("gpio: Add Realtek Otto GPIO support")
Signed-off-by: Sander Vanheule <sander@svanheule.net>
---
 drivers/gpio/gpio-realtek-otto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
index eeeb39bc171d..bd75401b549d 100644
--- a/drivers/gpio/gpio-realtek-otto.c
+++ b/drivers/gpio/gpio-realtek-otto.c
@@ -205,7 +205,7 @@ static void realtek_gpio_irq_handler(struct irq_desc *desc)
                status = realtek_gpio_read_isr(ctrl, lines_done / 8);
                port_pin_count = min(gc->ngpio - lines_done, 8U);
                for_each_set_bit(offset, &status, port_pin_count)
-                       generic_handle_domain_irq(gc->irq.domain, offset);
+                       generic_handle_domain_irq(gc->irq.domain, offset + lines_done);
        }

        chained_irq_exit(irq_chip, desc);
--
2.31.1
I already sent my last fixes PR to Linus yesterday, so I queued it
with other patches for next. It'll get backported anyway to stable
branches.

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help