Thread (5 messages) 5 messages, 2 authors, 2021-10-13

Re: [PATCH v2 03/20] gpio: mc33880: Drop if with an always false condition

From: Bartosz Golaszewski <hidden>
Date: 2021-10-13 17:53:41
Also in: linux-spi

On Tue, Oct 12, 2021 at 5:39 PM Uwe Kleine-König
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
An spi remove callback is only called for devices that probed
successfully. In this case this implies that mc33880_probe() set a
non-NULL driver data. So the check for mc being NULL is never true and
the check can be dropped.

Also the return value ofspi remove callbacks is ignored anyway.

Signed-off-by: Uwe Kleine-König <redacted>
---
 drivers/gpio/gpio-mc33880.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c
index f8194f7c6186..31d2be1bebc8 100644
--- a/drivers/gpio/gpio-mc33880.c
+++ b/drivers/gpio/gpio-mc33880.c
@@ -139,8 +139,6 @@ static int mc33880_remove(struct spi_device *spi)
        struct mc33880 *mc;

        mc = spi_get_drvdata(spi);
-       if (!mc)
-               return -ENODEV;

        gpiochip_remove(&mc->chip);
        mutex_destroy(&mc->lock);
--
2.30.2
Applied, thanks!

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help