Hi Geert,

Thank you for the review.

On Thu, Oct 7, 2021 at 5:57 PM Geert Uytterhoeven [off-list ref] wrote:

Hi Prabhakar,

On Thu, Sep 30, 2021 at 2:17 PM Lad Prabhakar
[off-list ref] wrote:

quoted

On RZ/G2L SoC for Group-B pins, output impedance can be configured.
This patch documents "output-impedance" property in pincfg-node.yaml so
that other platforms requiring such feature can make use of this property.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

quoted

--- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml

@@ -114,6 +114,10 @@ properties:
     description: enable output on a pin without actively driving it
       (such as enabling an output buffer)

+  output-impedance:

output-impedance-ohms (ugh, the standard suffix is plural)

Yes, I know only one other property has a standard unit suffix from
dt-schema/schemas/property-units.yaml. Should we add properties
including standard unit suffixes, and deprecate the old ones?

Yes, that should be the way to go forward.

Cheers,
Prabhakar

quoted

+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: set the pins output impedance at most X ohm
+
   output-low:
     type: boolean
     description: set the pin to output mode with low level

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds