Thread (50 messages) 50 messages, 8 authors, 2021-10-19

Re: [PATCH v1 12/16] pinctrl: starfive: Add pinctrl driver for StarFive SoCs

From: Andy Shevchenko <hidden>
Date: 2021-10-19 09:52:32
Also in: linux-clk, linux-devicetree, linux-riscv, linux-serial, lkml

On Mon, Oct 18, 2021 at 07:02:43PM +0200, Emil Renner Berthing wrote:
On Mon, 18 Oct 2021 at 18:29, Andy Shevchenko [off-list ref] wrote:
quoted
On Mon, Oct 18, 2021 at 7:23 PM Andy Shevchenko
[off-list ref] wrote:
...
quoted
Having a second look I found even problematic error paths because of
mixing devm_*() with non-devm_*() calls, which only assures me that
your ->probe() error path is broken and should be revisited.
So do you want to expand on that now or should I send v2 first?
Here is not enough context anymore to point out. I expect one to have done
their homework anyway.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help