Re: [PATCH v3 01/27] Input: Simplify with dev_err_probe()
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2021-09-16 19:41:07
Also in:
linux-input, lkml, platform-driver-x86
On Fri, 2 Oct 2020 at 18:23, Krzysztof Kozlowski [off-list ref] wrote:
On Thu, Aug 27, 2020 at 08:58:02PM +0200, Krzysztof Kozlowski wrote:quoted
Hi, Changes since v2: 1. Add review tags, 2. Fixes after review (see individual patches). 3. Two new patches - 26 and 27.Hi Dmitry, Any comments here? Some of these nicely simplify the code or remove some lines.
Hi Dmitry, You never shared your thoughts about this simplification. Some of these could be redundant with Rob's work: https://lore.kernel.org/lkml/CAL_Jsq+ajm5aiAJfQdS2+2DO1ynBDHWha_7TsA4u-2qwd87y6g@mail.gmail.com/ (local) but I am not sure if it was merged. On the other hand there are here also few other changes like:
gpio: Add devm_fwnode_gpiod_get_optional() helpers Input: gpio_keys - Simplify with dev_err_probe()
which does: 8 insertions(+), 17 deletions(-) and these:
Input: bu21013_ts - Use local 'client->dev' variable in probe() Input: bu21029_ts - Use local 'client->dev' variable in probe()
Any comments? Best regards, Krzysztof
quoted
Krzysztof Kozlowski (27): Input: gpio_keys_polled - Simplify with dev_err_probe() Input: gpio-vibra - Simplify with dev_err_probe() Input: pwm-beeper - Simplify with dev_err_probe() Input: pwm-vibra - Simplify with dev_err_probe() Input: rotary_encoder - Simplify with dev_err_probe() Input: elan_i2c - Simplify with dev_err_probe() Input: bu21013_ts - Simplify with dev_err_probe() Input: bu21029_ts - Simplify with dev_err_probe() Input: chipone_icn8318 - Simplify with dev_err_probe() Input: cy8ctma140 - Simplify with dev_err_probe() Input: edf-ft5x06 - Simplify with dev_err_probe() Input: ektf2127 - Simplify with dev_err_probe() Input: elants_i2c - Simplify with dev_err_probe() Input: goodix - Simplify with dev_err_probe() Input: melfas_mip4 - Simplify with dev_err_probe() Input: pixcir_i2c_ts - Simplify with dev_err_probe() Input: raydium_i2c_ts - Simplify with dev_err_probe() Input: resistive-adc-touch - Simplify with dev_err_probe() Input: silead - Simplify with dev_err_probe() Input: sis_i2c - Simplify with dev_err_probe() Input: surface3_spi - Simplify with dev_err_probe() Input: sx8643 - Simplify with dev_err_probe() Input: bcm-keypad - Simplify with dev_err_probe() gpio: Add devm_fwnode_gpiod_get_optional() helpers Input: gpio_keys - Simplify with dev_err_probe() Input: bu21013_ts - Use local 'client->dev' variable in probe() Input: bu21029_ts - Use local 'client->dev' variable in probe() drivers/gpio/gpiolib-devres.c | 71 ++++++++++++++++++ drivers/input/keyboard/bcm-keypad.c | 14 ++-- drivers/input/keyboard/gpio_keys.c | 25 +++---- drivers/input/keyboard/gpio_keys_polled.c | 8 +-- drivers/input/misc/gpio-vibra.c | 20 ++---- drivers/input/misc/pwm-beeper.c | 19 ++--- drivers/input/misc/pwm-vibra.c | 20 ++---- drivers/input/misc/rotary_encoder.c | 8 +-- drivers/input/mouse/elan_i2c_core.c | 9 +-- drivers/input/touchscreen/bu21013_ts.c | 72 ++++++++----------- drivers/input/touchscreen/bu21029_ts.c | 53 ++++++-------- drivers/input/touchscreen/chipone_icn8318.c | 8 +-- drivers/input/touchscreen/cy8ctma140.c | 8 +-- drivers/input/touchscreen/edt-ft5x06.c | 10 +-- drivers/input/touchscreen/ektf2127.c | 8 +-- drivers/input/touchscreen/elants_i2c.c | 22 ++---- drivers/input/touchscreen/goodix.c | 40 +++-------- drivers/input/touchscreen/melfas_mip4.c | 9 +-- drivers/input/touchscreen/pixcir_i2c_ts.c | 38 ++++------ drivers/input/touchscreen/raydium_i2c_ts.c | 30 +++----- .../input/touchscreen/resistive-adc-touch.c | 8 +-- drivers/input/touchscreen/silead.c | 8 +-- drivers/input/touchscreen/sis_i2c.c | 20 ++---- drivers/input/touchscreen/surface3_spi.c | 13 +--- drivers/input/touchscreen/sx8654.c | 10 +-- include/linux/gpio/consumer.h | 30 ++++++++ 26 files changed, 253 insertions(+), 328 deletions(-) -- 2.17.1