Re: [PATCH V3 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp
From: Stephen Boyd <hidden>
Date: 2021-09-13 20:01:11
Also in:
linux-arm-msm, linux-devicetree, lkml
Quoting satya priya (2021-09-08 23:01:28)
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 371a2a9..434c1c6 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi@@ -239,6 +239,26 @@ cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>; }; +&soc { + gpio_keys {
Should be gpio-keys. Node names shouldn't have underscores. Typically underscores are replaced with dashes.
+ compatible = "gpio-keys";
+ label = "gpio-keys";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&key_vol_up_default>;
+
+ vol_up {Should be vol-up or volume-up.
quoted hunk ↗ jump to hunk
+ label = "volume_up"; + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; + linux,input-type = <1>; + linux,code = <KEY_VOLUMEUP>; + gpio-key,wakeup; + debounce-interval = <15>; + linux,can-disable; + }; + }; +}; + &uart5 { status = "okay"; };@@ -284,6 +304,17 @@ /* PINCTRL - additions to nodes defined in sc7280.dtsi */ +&pm7325_gpios { + key_vol_up_default: key_vol_up_default {
Should be key_vol_up_default: key-vol-up-default {
+ pins = "gpio6";
+ function = "normal";
+ input-enable;
+ bias-pull-up;
+ power-source = <0>;
+ qcom,drive-strength = <3>;
+ };
+};
+
&qup_uart5_default {
tx {
pins = "gpio46";