Re: [PATCH] ath9k: fix sleeping in atomic context
From: Kalle Valo <hidden>
Date: 2021-08-29 07:12:50
Also in:
linux-wireless
From: Kalle Valo <hidden>
Date: 2021-08-29 07:12:50
Also in:
linux-wireless
Miaoqing Pan [off-list ref] wrote:
The problem is that gpio_free() can sleep and the cfg_soc() can be
called with spinlocks held. One problematic call tree is:
--> ath_reset_internal() takes &sc->sc_pcu_lock spin lock
--> ath9k_hw_reset()
--> ath9k_hw_gpio_request_in()
--> ath9k_hw_gpio_request()
--> ath9k_hw_gpio_cfg_soc()
Remove gpio_free(), use error message instead, so we should make sure
there is no GPIO conflict.
Also remove ath9k_hw_gpio_free() from ath9k_hw_apply_gpio_override(),
as gpio_mask will never be set for SOC chips.
Signed-off-by: Miaoqing Pan <redacted>
Signed-off-by: Kalle Valo <redacted>Patch applied to ath-next branch of ath.git, thanks. 7c48662b9d56 ath9k: fix sleeping in atomic context -- https://patchwork.kernel.org/project/linux-wireless/patch/1628481916-15030-1-git-send-email-miaoqing@codeaurora.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches