Re: [PATCH] gpio: ucb1400: Use proper header
From: Andy Shevchenko <hidden>
Date: 2021-08-21 07:38:42
On Sat, Aug 21, 2021 at 1:27 AM Linus Walleij [off-list ref] wrote:
The UCB1400 implements a GPIO driver so it needs to include the <linux/gpio/driver.h> header, not the legacy <linux/gpio.h> header. Compile tested on pxa_defconfig.
...
#include <linux/module.h> #include <linux/ucb1400.h> +#include <linux/gpio/driver.h>
Can you add it in an order? ...
quoted hunk ↗ jump to hunk
--- a/include/linux/ucb1400.h +++ b/include/linux/ucb1400.h@@ -23,7 +23,7 @@ #include <sound/ac97_codec.h> #include <linux/mutex.h> #include <linux/platform_device.h> -#include <linux/gpio.h> +#include <linux/gpio/driver.h>
Ditto (to some extent) and the question here, do you still need it after adding to the C file? -- With Best Regards, Andy Shevchenko