[PATCH v2 2/3] irqdomain: Fix irq_domain_trim_hierarchy()
From: Maulik Shah <hidden>
Date: 2021-08-19 11:53:50
Also in:
linux-arm-msm, lkml
Subsystem:
irq domains (irq number mapping library), irq subsystem, the rest · Maintainers:
Thomas Gleixner, Linus Torvalds
Currently tail marker is moving along with parent domain irq data. Fix this to initialize only once from where all parent domain needs trimming. Also correct the valid irq chip check. Signed-off-by: Maulik Shah <redacted> --- kernel/irq/irqdomain.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 19e83e9..9f6187b 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c@@ -1235,7 +1235,7 @@ static int irq_domain_trim_hierarchy(unsigned int virq) */ for (irqd = irq_data->parent_data; irqd; irq_data = irqd, irqd = irqd->parent_data) { /* Can't have a valid irqchip after a trim marker */ - if (irqd->chip && tail) + if (!IS_ERR(irqd->chip) && tail) return -EINVAL; /* Can't have an empty irqchip before a trim marker */
@@ -1247,7 +1247,8 @@ static int irq_domain_trim_hierarchy(unsigned int virq) if (PTR_ERR(irqd->chip) != -ENOTCONN) return -EINVAL; - tail = irq_data; + if (!tail) + tail = irq_data; } }
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation