Re: [PATCH] pinctrl: pinctrl-zynq: Add warning for not to use 'io-standard'
From: Michal Simek <hidden>
Date: 2021-08-18 06:00:22
Also in:
linux-arm-kernel, lkml
On 8/18/21 7:53 AM, Sai Krishna Potthuri wrote:
quoted hunk ↗ jump to hunk
This patch add warning message saying 'io-standard' property is deprecated and instead use 'power-source' property for configuring power supplies. This gives an indication for Zynq pinctrl users to migrate to use 'power-source' property. Signed-off-by: Sai Krishna Potthuri <redacted> --- drivers/pinctrl/pinctrl-zynq.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c index a96af8a..5b269b6 100644 --- a/drivers/pinctrl/pinctrl-zynq.c +++ b/drivers/pinctrl/pinctrl-zynq.c@@ -1028,6 +1028,8 @@ static int zynq_pinconf_cfg_get(struct pinctrl_dev *pctldev, break; } case PIN_CONFIG_IOSTANDARD: + dev_warn(pctldev->dev, "io-standard is deprecated, please use power-source"); + fallthrough; case PIN_CONFIG_POWER_SOURCE: arg = zynq_pinconf_iostd_get(reg); break;@@ -1079,6 +1081,8 @@ static int zynq_pinconf_cfg_set(struct pinctrl_dev *pctldev, break; case PIN_CONFIG_IOSTANDARD: + dev_warn(pctldev->dev, "io-standard is deprecated, please use power-source"); + fallthrough; case PIN_CONFIG_POWER_SOURCE: if (arg <= zynq_iostd_min || arg >= zynq_iostd_max) { dev_warn(pctldev->dev,
Acked-by: Michal Simek <redacted> Linus: would be good to know how long we should keep the support for this deprecated dt property. Thanks, Michal