[PATCH v8 8/9] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
STALE1830d
LANDED: 3 (3M)
From: Jianqun Xu <hidden>
Date: 2021-08-16 01:21:45
Also in:
linux-devicetree, linux-rockchip, lkml
Subsystem:
arm/rockchip soc support, gpio subsystem, the rest · Maintainers:
Heiko Stuebner, Linus Walleij, Bartosz Golaszewski, Linus Torvalds
Revision v8 of 2 in this series; 1 review trailer (1 from subsystem maintainers); landed in mainline as 93103f6eb09c on 2021-08-16.
Revisions (2)
- v6 [diff vs current]
- v8 current
There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Jianqun Xu <redacted> --- v8: - none v7: - none v6: - add reviewed by heiko drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index b2be56040289..036b2d959503 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c@@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity);
@@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret;
--
2.25.1