Re: [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set
From: Lee Jones <hidden>
Date: 2021-08-05 13:30:37
Also in:
lkml
On Fri, 16 Jul 2021, Matthias Schiffer wrote:
quoted hunk ↗ jump to hunk
The driver was registering IRQ 0 when no IRQ was set. This leads to warnings with newer kernels. Clear the resource flags, so no resource is registered at all in this case. Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO") Signed-off-by: Matthias Schiffer <redacted> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- v2: add Fixes line v3: no changes drivers/mfd/tqmx86.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index ddddf08b6a4c..732013f40e4e 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c@@ -209,6 +209,8 @@ static int tqmx86_probe(struct platform_device *pdev) /* Assumes the IRQ resource is first. */ tqmx_gpio_resources[0].start = gpio_irq; + } else { + tqmx_gpio_resources[0].flags = 0;
Strange - why is this !0 in the first place?
} ocores_platfom_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id);
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog