Thread (2 messages) 2 messages, 2 authors, 2021-07-26

RE: [pinctrl:devel 6/11] drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function

From: Aisheng Dong <aisheng.dong@nxp.com>
Date: 2021-07-26 02:57:53

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

   drivers/pinctrl/freescale/pinctrl-imx8ulp.c: In function
'imx8ulp_pmx_gpio_set_direction':
quoted
quoted
drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning:
'pin_reg' is used uninitialized in this function [-Wuninitialized]
     228 |  reg = readl(ipctl->base + pin_reg->mux_reg);
         |                                   ^~
Jacky,
Can you fix it ASAP?

Regards
Aisheng
vim +/pin_reg +228 drivers/pinctrl/freescale/pinctrl-imx8ulp.c

   219
   220	static int imx8ulp_pmx_gpio_set_direction(struct pinctrl_dev
*pctldev,
   221						  struct pinctrl_gpio_range *range,
   222						  unsigned offset, bool input)
   223	{
   224		struct imx_pinctrl *ipctl = pinctrl_dev_get_drvdata(pctldev);
   225		const struct imx_pin_reg *pin_reg;
   226		u32 reg;
   227
 > 228		reg = readl(ipctl->base + pin_reg->mux_reg);
   229		if (input)
   230			reg = (reg & ~BM_OBE_ENABLED) | BM_IBE_ENABLED;
   231		else
   232			reg = (reg & ~BM_IBE_ENABLED) | BM_OBE_ENABLED;
   233		writel(reg, ipctl->base + pin_reg->mux_reg);
   234
   235		return 0;
   236	}
   237

---
0-DAY CI Kernel Test Service, Intel Corporation
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.
org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&amp;data=04%7C01%7
Caisheng.dong%40nxp.com%7C77d8ecb2644540665db008d94e14a97e%7C6
86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637626675696342246%
7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=YorpxeyuRjKeWxAJVEx6
xU9NmffBzS1Le3VkyQ8gPAA%3D&amp;reserved=0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help