Re: [PATCH 9/9] pinctrl/rockchip: drop the gpio related codes
From: Linus Walleij <hidden>
Date: 2021-07-23 10:12:14
Also in:
linux-rockchip
On Fri, Jun 18, 2021 at 8:29 AM Jianqun Xu [off-list ref] wrote:
With the patch to separate the gpio driver from the pinctrl driver, now the pinctrl-rockchip can drop the gpio related codes now. Signed-off-by: Jianqun Xu <redacted>
(...)
quoted hunk ↗ jump to hunk
#include <linux/bitops.h> -#include <linux/gpio/driver.h> -#include <linux/of_device.h> +#include <linux/gpio.h>
This is wrong. Do not introduce new users of <linux/gpio.h>. I don't want to delay the merge of the patch set because it has taken long enough as it is but please submit a patch removing include <linux/gpio.h>. You either need <linux/gpio/driver.h> or <linux/gpio/consumer.h> or both, or <linux/gpio.h> is just exploited to get other includes then figure out which ones. Yours, Linus Walleij