On Mon, Jul 26, 2021 at 4:25 PM Geert Uytterhoeven [off-list ref] wrote:

On Wed, Jul 21, 2021 at 9:16 PM Lad Prabhakar
[off-list ref] wrote:

...

quoted

+#define RZG2L_GPIO_PORT_GET_PINCNT(x)  (((x) >> 28) & 0x7)
+#define RZG2L_GPIO_PORT_GET_INDEX(x)   ((((x) & GENMASK(27, 20)) >> 20) & 0x7f)

It's funny one of them uses style "a" (no GENMASK() use), another
style "b" (GENMASK() is in use). I suggest being consistent: either
drop GENMASK() everywhere, or use them in all suitable places.

quoted

+#define RZG2L_SINGLE_PIN_GET_PORT(x)   (((x) >> 24) & 0x7f)
+#define RZG2L_SINGLE_PIN_GET_BIT(x)    ((((x) & GENMASK(23, 20)) >> 20) & 0x7)

Ditto.

-- 
With Best Regards,
Andy Shevchenko