Thread (9 messages) 9 messages, 3 authors, 2021-08-11

Re: [PATCH 3/3] pinctrl: ingenic: Add .max_register in regmap_config

From: Zhou Yanjie <hidden>
Date: 2021-07-24 06:44:02
Also in: linux-mips, lkml

Hi Paul,

On 2021/7/18 上午1:48, Paul Cercueil wrote:
Compute the max register from the GPIO chip offset and number of GPIO
chips.

This permits to read all registers from debugfs.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
  drivers/pinctrl/pinctrl-ingenic.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

Tested-by: 周琰杰 (Zhou Yanjie)<redacted>

quoted hunk ↗ jump to hunk
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
index 263498be8e31..2bbcb8063a16 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -3759,6 +3759,7 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
  	void __iomem *base;
  	const struct ingenic_chip_info *chip_info;
  	struct device_node *node;
+	struct regmap_config regmap_config;
  	unsigned int i;
  	int err;
  
@@ -3776,8 +3777,10 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
  	if (IS_ERR(base))
  		return PTR_ERR(base);
  
-	jzpc->map = devm_regmap_init_mmio(dev, base,
-			&ingenic_pinctrl_regmap_config);
+	regmap_config = ingenic_pinctrl_regmap_config;
+	regmap_config.max_register = chip_info->num_chips * chip_info->reg_offset;
+
+	jzpc->map = devm_regmap_init_mmio(dev, base, &regmap_config);
  	if (IS_ERR(jzpc->map)) {
  		dev_err(dev, "Failed to create regmap\n");
  		return PTR_ERR(jzpc->map);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help